Skip to content

ci: add os and node matrix to unit test jobs - #673

Merged
michaelfaith merged 2 commits into
mainfrom
ci/test-matrix
Nov 16, 2026
Merged

michaelfaith merged 2 commits into
mainfrom
ci/test-matrix

Conversation

@michaelfaith

Copy link
Copy Markdown
Contributor

This change updates the unit test execution in CI to use a test job for all the various versions node we support, and a separate test job for all three major OSes. Coverage will only be sent off to codecov on the ubuntu-latest run of the test_os job.

Note

We'll need to update merge checks at the point where it's ready to merge.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

Fixes #641

This change updates the unit test execution in CI to use a test job for all the various versions node we support, and a separate test job for all three major OSes.  Coverage will only be sent off to codecov on the `ubuntu-latest` run of the `test_os` job.

> [!NOTE]
> We'll need to update merge checks at the point where it's ready to merge.
@michaelfaith
michaelfaith marked this pull request as ready for review November 15, 2026 20:55
@michaelfaith
michaelfaith requested a review from a team November 15, 2026 20:55
Comment thread .github/workflows/ci.yml
- 24.0.0
- 24
- 25
- 26.0.0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ why the breakdown between the specific node version like 26.0.0 and 26? In this case we are capturing the first version of 24, 26 but the 22 minor version of 22, and then finally the latest of each of these versions.

Why not capture just the latest of the node versions we support in the range?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

22, 24, and 26 give the latest version for that major. So 26.0.0 is the first in the range, and 26 is the last in the range, so it covers the entire range we claim to support. Our package's engines is "node": ">=22.22.0". So this reflects all ranges that we claim to support. I left off min version for 23 and 25, because those are End of Life and I don't expect many people are using those.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm fair, should we just not include 23/25 to not incentivize anyone to use EoL versions? It also looks like v22 will be reaching EoL in a few months as well:

Screenshot 2026-11-15 at 9 09 28 PM

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, that's more of an argument for us to change our engines. As long as we have those versions in our engines (i.e. we claim to support them), then I think we should test that we actually do support them in some form.

@jdalrymple jdalrymple left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just questions, nothing blocking

@michaelfaith
michaelfaith merged commit efc3471 into main Nov 16, 2026
26 checks passed
@michaelfaith
michaelfaith deleted the ci/test-matrix branch November 16, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠 Tooling: add matrix to test step for testing multiple versions of node

2 participants